Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18855#discussion_r131544351
  
    --- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala 
---
    @@ -92,6 +92,31 @@ class DiskStoreSuite extends SparkFunSuite {
         assert(diskStore.getSize(blockId) === 0L)
       }
     
    +  test("blocks larger than 2gb") {
    +    val conf = new SparkConf()
    +    val diskBlockManager = new DiskBlockManager(conf, deleteFilesOnStop = 
true)
    +    val diskStore = new DiskStore(conf, diskBlockManager, new 
SecurityManager(conf))
    +
    +    val mb = 1024*1024
    --- End diff --
    
    nit: `1024 * 1024`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to