Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18111#discussion_r131562253 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -73,7 +73,10 @@ class HadoopMapReduceCommitProtocol(jobId: String, path: String) val stagingDir: String = committer match { // For FileOutputCommitter it has its own staging path called "work path". - case f: FileOutputCommitter => Option(f.getWorkPath.toString).getOrElse(path) + case f: FileOutputCommitter => + val workPath = f.getWorkPath + require(workPath != null, s"Committer has no workpath $f") + Option(workPath.toString).getOrElse(path) --- End diff -- I wonder the answer to this question ^ actually .. Wouldn't `Option(...).getOrElse(path)` be unnecessary?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org