Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18813#discussion_r131803127
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -775,7 +775,7 @@ object ScalaReflection extends ScalaReflection {
* Whether the fields of the given type is defined entirely by its
constructor parameters.
*/
def definedByConstructorParams(tpe: Type): Boolean = {
- tpe <:< localTypeOf[Product] || tpe <:<
localTypeOf[DefinedByConstructorParams]
+ tpe.dealias <:< localTypeOf[Product] || tpe.dealias <:<
localTypeOf[DefinedByConstructorParams]
--- End diff --
Oh. no. `definedByConstructorParams` is called in `ExpressionEncoder` too.
So we should do dealias here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
