Github user yaooqinn commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18648#discussion_r131807040
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala 
---
    @@ -312,7 +323,7 @@ private[spark] object HiveUtils extends Logging {
             hadoopConf = hadoopConf,
             execJars = jars.toSeq,
             config = configurations,
    -        isolationOn = true,
    +        isolationOn = isCliSessionState(),
    --- End diff --
    
    @cloud-fan According to 
[HiveClientImpl.scala#L140](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L140),
 the cliSessionState shall be reused. But because of IsolateClientClassloader, 
[HiveClientImpl.scala#L138](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L138)
 will be `null`. Then it always goes to the `else` branch to create and start a 
new `session.SessionState`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to