Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18492#discussion_r131820095
--- Diff: core/src/main/java/org/apache/spark/SparkFirehoseListener.java ---
@@ -140,6 +140,16 @@ public void onBlockUpdated(SparkListenerBlockUpdated
blockUpdated) {
}
@Override
+ public void
onSpeculativeTaskSubmitted(SparkListenerSpeculativeTaskSubmitted
speculativeTask) {
+ onEvent(speculativeTask);
+ }
+
+ @Override
+ public void onExtraExecutorNeeded() {
+ onEvent(null);
--- End diff --
`SparkFirehoseListener` is a public API and users may assume `onEvent` will
never accept null, how about we just do nothing here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
