Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/18873
  
    @felixcheung, Yes, that's right. I would support this if it was a simple 
backport and the Jenkins build still fails.
    
    However, now it was fixed and the actual gain looks quite small - if I 
understood correctly, this change is useful only when someone manually runs 
tests by Python 2.6 in branch-2.1, whereas the changes look introducing 
untested workarounds although I know most of the current changes are correct as 
I already tried almost identical changes in my local before.
    
    Another potential problem might be, backporting other changes would be 
harder. As an extreme example, there was actually a mistake during backporting 
some changes into this script before and I corrected this - 
https://github.com/apache/spark/commit/4a67541db24f47f8101a32cb83153bca2dabc759
    
    I personally would like to avoid this change unless there are other good 
reasons to make this change alone in this branch ..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to