Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r131890999 --- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala --- @@ -92,6 +92,31 @@ class DiskStoreSuite extends SparkFunSuite { assert(diskStore.getSize(blockId) === 0L) } + test("blocks larger than 2gb") { + val conf = new SparkConf() + val diskBlockManager = new DiskBlockManager(conf, deleteFilesOnStop = true) + val diskStore = new DiskStore(conf, diskBlockManager, new SecurityManager(conf)) + + val mb = 1024 * 1024 + val gb = 1024L * mb + + val blockId = BlockId("rdd_1_2") + diskStore.put(blockId) { chan => + val arr = new Array[Byte](mb) + for { + _ <- 0 until 2048 + } { + val buf = ByteBuffer.wrap(arr) + while (buf.hasRemaining()) { + chan.write(buf) + } + } + } + + val blockData = diskStore.getBytes(blockId) + assert(blockData.size == 2 * gb) --- End diff -- test with 3gb to be more explicit that it's larger than 2gb?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org