Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18799#discussion_r132050716
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLogSuite.scala
 ---
    @@ -259,6 +259,19 @@ class HDFSMetadataLogSuite extends SparkFunSuite with 
SharedSQLContext {
           fm.rename(path2, path3)
         }
       }
    +
    +  test("verifyBatchIds") {
    +    import HDFSMetadataLog.verifyBatchIds
    +    verifyBatchIds(Seq(1L, 2L, 3L), Some(1L), Some(3L))
    +    verifyBatchIds(Seq(1L), Some(1L), Some(1L))
    --- End diff --
    
    you didnt test the valid cases when one of the start or end is None.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to