Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18849#discussion_r132059925
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -908,7 +909,13 @@ private[hive] object HiveClientImpl {
         }
         // after SPARK-19279, it is not allowed to create a hive table with an 
empty schema,
         // so here we should not add a default col schema
    -    if (schema.isEmpty && DDLUtils.isDatasourceTable(table)) {
    +    //
    +    // Because HiveExternalCatalog sometimes writes back "raw" tables that 
have not been
    +    // completely translated to Spark's view, the provider information 
needs to be looked
    +    // up in two places.
    +    val provider = table.provider.orElse(
    --- End diff --
    
    What is the second exception? Could you explain more? If this is fixing a 
different bug, could you open a new JIRA and put it in the PR title?
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to