Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18787#discussion_r132246475
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
 ---
    @@ -65,15 +65,35 @@
       final Row row;
     
       public static ColumnarBatch allocate(StructType schema, MemoryMode 
memMode) {
    -    return new ColumnarBatch(schema, DEFAULT_BATCH_SIZE, memMode);
    +    return allocate(schema, memMode, DEFAULT_BATCH_SIZE);
       }
     
       public static ColumnarBatch allocate(StructType type) {
    -    return new ColumnarBatch(type, DEFAULT_BATCH_SIZE, 
DEFAULT_MEMORY_MODE);
    +    return allocate(type, DEFAULT_MEMORY_MODE, DEFAULT_BATCH_SIZE);
       }
     
       public static ColumnarBatch allocate(StructType schema, MemoryMode 
memMode, int maxRows) {
    -    return new ColumnarBatch(schema, maxRows, memMode);
    +    ColumnVector[] columns = allocateCols(schema, maxRows, memMode);
    +    return new ColumnarBatch(schema, columns, maxRows);
    +  }
    +
    +  private static ColumnVector[] allocateCols(StructType schema, int 
maxRows, MemoryMode memMode) {
    +    ColumnVector[] columns = new ColumnVector[schema.size()];
    +    for (int i = 0; i < schema.fields().length; ++i) {
    +      StructField field = schema.fields()[i];
    +      columns[i] = ColumnVector.allocate(maxRows, field.dataType(), 
memMode);
    +    }
    +    return columns;
    +  }
    +
    +  public static ColumnarBatch createReadOnly(
    +      StructType schema,
    +      ReadOnlyColumnVector[] columns,
    +      int numRows) {
    +    assert(schema.length() == columns.length);
    +    ColumnarBatch batch = new ColumnarBatch(schema, columns, numRows);
    +    batch.setNumRows(numRows);
    --- End diff --
    
    The `ArrowColumnVector.valueCount` 
[here](https://github.com/BryanCutler/spark/blob/23d19dfde53d02c37a2c20f67c9816a73bd57cd2/sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ArrowColumnVector.java#L35)
 would need to be moved to `ReadOnlyColumnVector` which could go in place of 
the capacity.  If @ueshin thinks that's ok to do so here, I can add that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to