Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18736#discussion_r132253487
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala 
---
    @@ -90,10 +92,22 @@ class HashingTF @Since("1.4.0") (@Since("1.4.0") 
override val uid: String)
       @Since("2.0.0")
       def setBinary(value: Boolean): this.type = set(binary, value)
     
    +  /**
    +   * Returns the index of the input term.
    +   */
    +  @Since("2.3.0")
    +  def indexOf(term: Any): Int = {
    +    if (hashingTF != null) {
    +      hashingTF.indexOf(term)
    --- End diff --
    
    Another problem:
    
    When the parameter changed (numFeatures, binary), you should immediately 
create a new hashTF object  to replace the old one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to