Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18630#discussion_r132274194
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -300,28 +298,14 @@ object SparkSubmit extends CommandLineUtils {
         }
         val isYarnCluster = clusterManager == YARN && deployMode == CLUSTER
         val isMesosCluster = clusterManager == MESOS && deployMode == CLUSTER
    +    val isStandAloneCluster = clusterManager == STANDALONE && deployMode 
== CLUSTER
     
    -    if (!isMesosCluster) {
    +    if (!isMesosCluster && !isStandAloneCluster) {
           // Resolve maven dependencies if there are any and add classpath to 
jars. Add them to py-files
           // too for packages that include Python code
    -      val exclusions: Seq[String] =
    -      if (!StringUtils.isBlank(args.packagesExclusions)) {
    -        args.packagesExclusions.split(",")
    -      } else {
    -        Nil
    -      }
    -
    -      // Create the IvySettings, either load from file or build defaults
    -      val ivySettings = 
args.sparkProperties.get("spark.jars.ivySettings").map { ivySettingsFile =>
    -        SparkSubmitUtils.loadIvySettings(ivySettingsFile, 
Option(args.repositories),
    -          Option(args.ivyRepoPath))
    -      }.getOrElse {
    -        SparkSubmitUtils.buildIvySettings(Option(args.repositories), 
Option(args.ivyRepoPath))
    -      }
    -
    -      val resolvedMavenCoordinates = 
SparkSubmitUtils.resolveMavenCoordinates(args.packages,
    -        ivySettings, exclusions = exclusions)
    -
    +      val resolvedMavenCoordinates =
    +      DependencyUtils.resolveMavenDepndencies(args.packagesExclusions, 
args.packages,
    --- End diff --
    
    should be an indention here.  Maybe this instead?
    ```
    val resolvedMavenCoordinates = 
DependencyUtils.resolveMavenDepndencies(args.packagesExclusions, 
      args.packages, ivySettings, exclusions = exclusions)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to