Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2563#discussion_r18324999
  
    --- Diff: python/pyspark/sql.py ---
    @@ -205,6 +234,16 @@ def __str__(self):
             return "ArrayType(%s,%s)" % (self.elementType,
                                          str(self.containsNull).lower())
     
    +    simpleString = 'array'
    +
    +    def jsonValue(self):
    +        return {
    +            self.simpleString: {
    +                'type': self.elementType.jsonValue(),
    +                'containsNull': self.containsNull
    +            }
    +        }
    --- End diff --
    
    Any suggestions about indenting and wrapping complex nested Python data 
structure like this? I checked PEP8 while adding these lines, but didn't find 
useful guidelines for this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to