Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18901#discussion_r132379527
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -516,6 +516,10 @@ object SparkSubmit extends CommandLineUtils {
         if (deployMode == CLIENT || isYarnCluster) {
           childMainClass = args.mainClass
           if (isUserJar(args.primaryResource)) {
    +        val hadoopConf = new HadoopConfiguration()
    +        args.primaryResource =
    +          Option(args.primaryResource).map(
    +            downloadFile(_, targetDir, args.sparkProperties, 
hadoopConf)).orNull
             childClasspath += args.primaryResource
           }
           if (args.jars != null) { childClasspath ++= args.jars.split(",") }
    --- End diff --
    
    For the feature completeness, we should guard out users who specify remote 
jars with `--jars` in cluster mode, your use case of HBase is just one special 
case, user could specify HBase dependencies with `--jars`, it is feasible. One 
the contrary, you can also specify a local `primaryResource` as a workaround.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to