Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18899
Check what? you're just saving the extra call to numNonZeroes. Change the
declaration like so:
```
def toSparse: SparseVector = toSparse(numNonzeros)
private[linalg] def toSparse(nnz: Int): SparseVector
```
Then make the implementations override the new private method and use the
given nnz arg, and change `compressed` to pass the `nnz` value it has already
computed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
