Github user mike0sv commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18488#discussion_r132489991
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java
 ---
    @@ -79,7 +79,7 @@ public ExpressionInfo(
             assert name != null;
             assert arguments != null;
             assert examples != null;
    -        assert examples.isEmpty() || examples.startsWith("\n    
Examples:");
    +        assert examples.isEmpty() || 
examples.startsWith(System.lineSeparator() + "    Examples:");
    --- End diff --
    
    No, but without it it's not possible to run tests if you have different 
line separators (on windows for example)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to