Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r132578914
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2304,7 +2304,15 @@ object functions {
* @group string_funcs
* @since 1.5.0
*/
- def ltrim(e: Column): Column = withExpr {StringTrimLeft(e.expr) }
+ def ltrim(e: Column): Column = withExpr {StringTrimLeft(e.expr)}
--- End diff --
Hello Sean, sorry, just want to clarify whether I should change the
existing three trim function style or not. The above example is from existing
trim function (@since 1.5.0). Should I leave them as it is? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
