GitHub user ash211 opened a pull request:

    https://github.com/apache/spark/pull/18913

    [SPARK-21563][CORE] Fix race condition when serializing TaskDescriptions 
and adding jars

    ## What changes were proposed in this pull request?
    
    Fix the race condition when serializing TaskDescriptions and adding jars by 
keeping the set of jars and files for a TaskSet constant across the lifetime of 
the TaskSet.  Otherwise TaskDescription serialization can produce an invalid 
serialization when new file/jars are added concurrently as the TaskDescription 
is serialized.
    
    ## How was this patch tested?
    
    Additional unit test ensures jars/files contained in the TaskDescription 
remain constant throughout the lifetime of the TaskSet.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ash211/spark SPARK-21563

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18913.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18913
    
----
commit e874fbeeff532c4351ba7318c750cd322c4a24f5
Author: Andrew Ash <and...@andrewash.com>
Date:   2017-08-10T23:32:15Z

    Add test

commit b06425f7267e2f0e478000c30b60b963291aacb0
Author: Andrew Ash <and...@andrewash.com>
Date:   2017-08-10T23:40:49Z

    Fix the test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to