Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18843#discussion_r132621976
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1139,9 +1154,14 @@ class SQLConf extends Serializable with Logging {
     
       def windowExecBufferSpillThreshold: Int = 
getConf(WINDOW_EXEC_BUFFER_SPILL_THRESHOLD)
     
    +  def windowExecBufferInMemoryThreshold: Int = 
getConf(WINDOW_EXEC_BUFFER_IN_MEMORY_THRESHOLD)
    +
       def sortMergeJoinExecBufferSpillThreshold: Int =
         getConf(SORT_MERGE_JOIN_EXEC_BUFFER_SPILL_THRESHOLD)
     
    +  def sortMergeJoinExecBufferInMemoryThreshold: Int =
    --- End diff --
    
    Sure. Since there was no in-memory buffer for cartesian product before, I 
am using a conservative value 4096 for the in-memory buffer threshold. However, 
the spill threshold is set to 
`UnsafeExternalSorter.DEFAULT_NUM_ELEMENTS_FOR_SPILL_THRESHOLD` like it was 
before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to