GitHub user neoremind opened a pull request:
https://github.com/apache/spark/pull/18922
[SPARK-21701][CORE] Enable RPC client to use SO_RCVBUF, SO_SNDBUF and
SO_BACKLOG in SparkConf
## What changes were proposed in this pull request?
1. TCP parameters like SO_RCVBUF, SO_SNDBUF and SO_BACKLOG can be set in
`SparkConf`, and `org.apache.spark.network.server.TransportServer` can use
those parameters to build server by leveraging netty. But for
`TransportClientFactory`, there is no such way to set those parameters from
`SparkConf`. This could be inconsistent in server and client side when people
set parameters in `SparkConf`. So this PR make RPC client to be enable to use
those TCP parameters as well.
2. Add some comments to `MessageDecoder` class to show how wire format
looks like for a RPC message and draw a vivid graph to present to detailed wire
protocol.
## How was this patch tested?
Existing tests and refine asking non-existent endpoint test case in
`RpcEnvSuite`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neoremind/spark SPARK-21701
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18922.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18922
----
commit 09734e2a1cf611bfb05e5873f55e9423f8851fe8
Author: xu.zhang <[email protected]>
Date: 2017-08-11T14:06:15Z
1. Enable RPC client to use ` SO_RCVBUF` and ` SO_SNDBUF` and `SO_BACKLOG`
in SparkConf.
2. Add Javadoc comment in MessageEncoder class.
3. Refine test case of asking non-existent endpoint in RPC test suite.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
