Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/18925#discussion_r132795536
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -779,10 +780,16 @@ case object OneRowRelation extends LeafNode {
}
/** A logical plan for `dropDuplicates`. */
+case object Deduplicate {
+ def apply(keys: Seq[Attribute], child: LogicalPlan): Deduplicate = {
+ Deduplicate(keys, child, child.outputMode)
+ }
+}
+
case class Deduplicate(
keys: Seq[Attribute],
child: LogicalPlan,
- streaming: Boolean) extends UnaryNode {
+ originalOutputMode: OutputMode) extends UnaryNode {
--- End diff --
The intent here is that callers who need a Deduplicate will use the
two-argument form in the Object, which will then use the constructor to
preserve the output mode of the child.
A val defined inside the case class isn't accounted for by copy(), which
caused test failures when I tried it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
