Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18931
Ran with `aggregate with randomized keys` benchmark in `AggregateBenchmark`
to know if it will bring performance regression for the cases of no long
generated function.
Before this patch:
Java HotSpot(TM) 64-Bit Server VM 1.8.0_102-b14 on Linux 4.9.36-moby
Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
Aggregate w keys: Best/Avg Time(ms) Rate(M/s)
Per Row(ns) Relative
------------------------------------------------------------------------------------------------
codegen = F 8817 / 8853 9.5
105.1 1.0X
codegen = T hashmap = F 4904 / 4999 17.1
58.5 1.8X
codegen = T hashmap = T 2040 / 2256 41.1
24.3 4.3X
After this patch:
Java HotSpot(TM) 64-Bit Server VM 1.8.0_102-b14 on Linux 4.9.36-moby
Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
Aggregate w keys: Best/Avg Time(ms) Rate(M/s)
Per Row(ns) Relative
------------------------------------------------------------------------------------------------
codegen = F 8347 / 8388 10.1
99.5 1.0X
codegen = T hashmap = F 5112 / 5146 16.4
60.9 1.6X
codegen = T hashmap = T 2008 / 2365 41.8
23.9 4.2X
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]