Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18929
Maybe @vanzin can weigh in here, because the real question is whether these
constants in the launcher module are meant to be _the_ single definition of
them used throughout the code. core depends on launcher and uses these
constants a little bit, but not consistently. Most of the other code doesn't
seem to use it. That is, there are hundreds more changes like this you could
make.
Consistency is good. In contrast, there are only about 8 usages of these
constants outside the launcher module. Is it simpler to achieve some
consistency by removing those usages? Then it seems like a small step backwards
to not use them (and yet declare them), but is also much less change.
In the end, this is why I don't know if it's worth trying to standardize,
because it is also hard to keep it standard anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
