Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18940#discussion_r133077743
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -104,15 +105,22 @@ public ExternalShuffleBlockResolver(TransportConf
conf, File registeredExecutorF
Executor directoryCleaner) throws IOException {
this.conf = conf;
this.registeredExecutorFile = registeredExecutorFile;
- int indexCacheEntries =
conf.getInt("spark.shuffle.service.index.cache.entries", 1024);
+ String indexCacheSize =
conf.get("spark.shuffle.service.index.cache.size", "100m");
CacheLoader<File, ShuffleIndexInformation> indexCacheLoader =
new CacheLoader<File, ShuffleIndexInformation>() {
public ShuffleIndexInformation load(File file) throws
IOException {
return new ShuffleIndexInformation(file);
}
};
- shuffleIndexCache = CacheBuilder.newBuilder()
-
.maximumSize(indexCacheEntries).build(indexCacheLoader);
+ shuffleIndexCache =
+ CacheBuilder.newBuilder()
+
.maximumWeight(JavaUtils.byteStringAsBytes(indexCacheSize))
--- End diff --
nit: these lines are indented way too far (the previous code was, too).
See block above this one for example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
