Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/18855#discussion_r133144224
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1415,6 +1415,79 @@ class BlockManagerSuite extends SparkFunSuite with
Matchers with BeforeAndAfterE
super.fetchBlockSync(host, port, execId, blockId)
}
}
+
+ def testGetOrElseUpdateForLargeBlock(storageLevel: StorageLevel) {
--- End diff --
@cloud-fan , @vanzin ,
taking the 'parameterized approach', I'd remove most of the tests from
`BlockManagerSuite` as they'd require propagating this parameter to too many
subsystems.
so, I'm going to modify `DiskStore` and `DiskStoreSuite` to use such a
parameter, I'm not sure about leaving a test-case in `BlockManagerSuite` that
tests `DISK_ONLY` persistence, what do you guys think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
