Github user ProtD commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18872#discussion_r133150156
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
 ---
    @@ -109,14 +112,15 @@ class LibSVMRelationSuite extends SparkFunSuite with 
MLlibTestSparkContext {
       test("write libsvm data and read it again") {
         val df = spark.read.format("libsvm").load(path)
         val tempDir2 = new File(tempDir, "read_write_test")
    --- End diff --
    
    `Utils.createTempDir` seems to be a nicer way. The directory is 
automatically deleted when VM shuts down, so I believe no manual cleanup (cf. 
comment lower) is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to