Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18933#discussion_r133229705
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -912,6 +912,14 @@ object SQLConf {
           .intConf
           .createWithDefault(10000)
     
    +  val PANDAS_TIMEZONE_AWARE =
    --- End diff --
    
    There are other parts of the pyspark that doesn't use session local 
timezone. For instance, df.collect() and (maybe) python udf execution.
    
    I am worried that having those to be inconsistent (some use local timezone, 
some doesn't) and complex (one configuration for each of these functionality?)
    
    While it will be harder to fix, but how about we use one configuration to 
control the behavior of `df.toPandas()` and `df.collect()` and python udf 
regarding session local timezone?
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to