Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18519#discussion_r133290641
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -95,6 +99,12 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
       // The num of current max ExecutorId used to re-register appMaster
       @volatile protected var currentExecutorIdCounter = 0
     
    +  // hadoop token manager used by some sub-classes (e.g. Mesos)
    +  protected var hadoopDelegationTokenManager: 
Option[HadoopDelegationTokenManager] = None
    +
    +  // Hadoop delegation tokens to be sent to the executors.
    +  protected var hadoopDelegationCreds: Option[Array[Byte]] = None
    --- End diff --
    
    This should be a `val`; you don't need to set in in the subclass. Because 
there might be some initialization order issue, it might need to be a `lazy 
val`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to