Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18955#discussion_r133371781
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2658,4 +2658,9 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
checkAnswer(sql("SELECT __auto_generated_subquery_name.i from
(SELECT i FROM v)"), Row(1))
}
}
+
+ test("SPARK-21743: top-most limit should not cause memory leak") {
+ // In unit test, Spark will fail the query if memory leak detected.
--- End diff --
did you try this test in spark shell? We only throw exception for memory
leak if `spark.unsafe.exceptionOnMemoryLeak` is true. But this config is false
by default, and is true in unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
