Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133479509
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends QueryTest with
SharedSQLContext with TestJsonData {
}
}
}
+
+ test("SPARK-21677: json_tuple throws NullPointException when column is
null as string type") {
+ checkAnswer(sql(
+ """
+ |SELECT json_tuple('{"a" : 1, "b" : 2}'
+ |, cast(NULL AS STRING), 'b'
+ |, cast(NULL AS STRING), 'a')
+ """.stripMargin), Row(null, "2", null, "1"))
+
+ // mixes constant field name and non constant one
+ withTempView("jsonTable") {
+ Seq(("""{"a": 1, "b": 2}""", "a", "b"))
+ .toDF("jsonField", "a", "b")
+ .createOrReplaceTempView("jsonTable")
+
+ checkAnswer(
+ sql("""SELECT json_tuple(jsonField, b, cast(NULL AS STRING), 'a')
FROM jsonTable"""),
--- End diff --
will move L2053 to json-functions.sql
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
