Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/18950#discussion_r133502797
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -314,7 +316,7 @@ private[spark] class ExecutorAllocationManager(
// Do not change our target while we are still initializing,
// Otherwise the first job may have to ramp up unnecessarily
0
- } else if (maxNeeded < numExecutorsTarget) {
+ } else if (maxNeeded <= numExecutorsTarget) {
// The target number exceeds the number we actually need, so stop
adding new
--- End diff --
yeah I don't think this change hurts, but unless you have a reason for
changing it, I'd prefer to leave it just for when we need to dig through
history.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
