Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18958#discussion_r133626997
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
 ---
    @@ -505,18 +500,12 @@ public void filterNullsInColumn(int ordinal) {
         nullFilteredColumns.add(ordinal);
       }
     
    -  private ColumnarBatch(StructType schema, int maxRows, MemoryMode 
memMode) {
    +  public ColumnarBatch(StructType schema, ColumnVector[] columns, int 
capacity) {
         this.schema = schema;
    -    this.capacity = maxRows;
    -    this.columns = new ColumnVector[schema.size()];
    +    this.columns = columns;
    +    this.capacity = capacity;
    --- End diff --
    
    I found some places referring `ColumnarBatch.capacity()`, so I'd be a 
little conservative to do that for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to