Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/18940#discussion_r133782968
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -104,15 +105,21 @@ public ExternalShuffleBlockResolver(TransportConf
conf, File registeredExecutorF
Executor directoryCleaner) throws IOException {
this.conf = conf;
this.registeredExecutorFile = registeredExecutorFile;
- int indexCacheEntries =
conf.getInt("spark.shuffle.service.index.cache.entries", 1024);
+ String indexCacheSize =
conf.get("spark.shuffle.service.index.cache.size", "100m");
--- End diff --
internal/config is in spark core not in the common/network code. we
shouldn't be using the core version here as it will add an extra dependency
that isn't needed and then will be required to ship in like the external
shuffle jar, etc.
I prefer to leave it as is and if we want a config builder in the common
network code we do that as a separate jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
