Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18993#discussion_r133941559
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -54,14 +54,6 @@ trait BaseLimitExec extends UnaryExecNode with
CodegenSupport {
val limit: Int
override def output: Seq[Attribute] = child.output
- // Do not enable whole stage codegen for a single limit.
- override def supportCodegen: Boolean = child match {
- case plan: CodegenSupport => plan.supportCodegen
- case _ => false
--- End diff --
This is wrong, we may have more operators above `Limit`, so it's not a
single `Limit`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]