Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/18935#discussion_r134050644
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/NettyMemoryMetrics.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.network.util;
+
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.util.*;
+
+import com.codahale.metrics.Gauge;
+import com.codahale.metrics.Metric;
+import com.codahale.metrics.MetricRegistry;
+import com.codahale.metrics.MetricSet;
+import com.google.common.annotations.VisibleForTesting;
+import io.netty.buffer.PoolArenaMetric;
+import io.netty.buffer.PooledByteBufAllocator;
+import io.netty.buffer.PooledByteBufAllocatorMetric;
+
+/**
+ * A Netty memory metrics class to collect metrics from Netty
PooledByteBufAllocator.
+ */
+public class NettyMemoryMetrics implements MetricSet {
+
+ private final PooledByteBufAllocator pooledAllocator;
+
+ private final boolean verboseMetricsEnabled;
+
+ private final Map<String, Metric> allMetrics;
+
+ private final String metricPrefix;
+
+ @VisibleForTesting
+ final static Set<String> VERBOSE_METRICS = new HashSet<>();
+ static {
+ VERBOSE_METRICS.addAll(Arrays.asList(
+ "numAllocations",
+ "numTinyAllocations",
+ "numSmallAllocations",
+ "numNormalAllocations",
+ "numHugeAllocations",
+ "numDeallocations",
+ "numTinyDeallocations",
+ "numSmallDeallocations",
+ "numNormalDeallocations",
+ "numHugeDeallocations",
+ "numActiveAllocations",
+ "numActiveTinyAllocations",
+ "numActiveSmallAllocations",
+ "numActiveNormalAllocations",
+ "numActiveHugeAllocations",
+ "numActiveBytes"));
+ }
+
+ public NettyMemoryMetrics(PooledByteBufAllocator pooledAllocator,
+ String metricPrefix,
+ TransportConf conf) {
+ this.pooledAllocator = pooledAllocator;
+ this.allMetrics = new HashMap<>();
+ this.metricPrefix = metricPrefix;
+ this.verboseMetricsEnabled = conf.verboseMetrics();
+
+ registerMetrics(this.pooledAllocator);
+ }
+
+ private void registerMetrics(PooledByteBufAllocator allocator) {
+ PooledByteBufAllocatorMetric pooledAllocatorMetric =
allocator.metric();
+
+ // Register general metrics.
+ allMetrics.put(MetricRegistry.name(metricPrefix, "usedHeapMemory"),
+ (Gauge<Long>) () -> pooledAllocatorMetric.usedHeapMemory());
+ allMetrics.put(MetricRegistry.name(metricPrefix, "usedDirectMemory"),
+ (Gauge<Long>) () -> pooledAllocatorMetric.usedDirectMemory());
+
+ if (verboseMetricsEnabled) {
+ int directArenaIndex = 0;
+ for (PoolArenaMetric metric : pooledAllocatorMetric.directArenas()) {
+ registerArenaMetric(metric, "directArena" + directArenaIndex);
+ directArenaIndex++;
+ }
+
+ int heapArenaIndex = 0;
+ for (PoolArenaMetric metric : pooledAllocatorMetric.heapArenas()) {
+ registerArenaMetric(metric, "heapArena" + heapArenaIndex);
+ heapArenaIndex++;
+ }
+ }
+ }
+
+ private void registerArenaMetric(PoolArenaMetric arenaMetric, String
arenaName) {
+ for (String methodName : VERBOSE_METRICS) {
+ Method m;
+ try {
+ m = PoolArenaMetric.class.getMethod(methodName);
+ } catch (Exception e) {
+ // Failed to find metric related method, ignore this metric.
+ continue;
+ }
+
+ if (!Modifier.isPublic(m.getModifiers())) {
+ // Ignore non-public methods.
+ continue;
+ }
+
+ Class<?> returnType = m.getReturnType();
+ String metricName = MetricRegistry.name(metricPrefix, arenaName,
m.getName());
--- End diff --
These metrics looks interesting, but do you think having them separated out
by arena is helpful? Seems like we want a view of these metrics which sums
them over all arenas?
(Perhaps this is some ignornance of how arenas work in netty ... would help
to seem some example metrics you get from it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
