Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/18029#discussion_r134067791
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala
---
@@ -308,7 +308,6 @@ object KinesisInputDStream {
private[kinesis] val DEFAULT_KINESIS_ENDPOINT_URL: String =
"https://kinesis.us-east-1.amazonaws.com";
private[kinesis] val DEFAULT_KINESIS_REGION_NAME: String = "us-east-1"
- private[kinesis] val DEFAULT_INITIAL_POSITION_IN_STREAM:
InitialPositionInStream =
- InitialPositionInStream.LATEST
+ private[kinesis] val DEFAULT_INITIAL_POSITION_IN_STREAM: InitialPosition
= InitialPosition.latest
--- End diff --
*nit* Rename this to ```DEFAULT_INITIAL_POSITION``` to reflect the new
class name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
