Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18999#discussion_r134123358
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -659,19 +659,77 @@ def distinct(self):
return DataFrame(self._jdf.distinct(), self.sql_ctx)
@since(1.3)
- def sample(self, withReplacement, fraction, seed=None):
+ def sample(self, withReplacement=None, fraction=None, seed=None):
"""Returns a sampled subset of this :class:`DataFrame`.
+ :param withReplacement: Sample with replacement or not (default
False).
+ :param fraction: Fraction of rows to generate, range [0.0, 1.0].
+ :param seed: Seed for sampling (default a random seed).
+
.. note:: This is not guaranteed to provide exactly the fraction
specified of the total
count of the given :class:`DataFrame`.
- >>> df.sample(False, 0.5, 42).count()
- 2
- """
- assert fraction >= 0.0, "Negative fraction value: %s" % fraction
--- End diff --
I'd do the check in python, so the error message is more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
