Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18810
(copied from jira for just-in-case) Just for your information, I checked
the performance changes of TPCDS before/after the pr #18810; the pr affected
Q17/Q66 only (that is, they have too long codegen'd functions). The changes are
as follows (just run TPCDSQueryBenchmark);
Q17:
https://github.com/apache/spark/blob/master/sql/core/src/test/resources/tpcds/q17.sql
Q66:
https://github.com/apache/spark/blob/master/sql/core/src/test/resources/tpcds/q66.sql
```
Q17 w/o this pr, 3224.0 --> q17 w/this pr, 2627.0 (perf. improvement)
Q66 w/o this pr, 1712.0 --> q66 w/this pr, 3032.0 (perf. regression)
```
It seems their queries have gen'd funcs with 2800~2900 lines, so if we set
2900 at spark.sql.codegen.maxLinesPerFunction, we could keep the previous
performance w/o pr18810.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
