Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19002#discussion_r134140826
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -255,6 +256,18 @@ class OracleIntegrationSuite extends
DockerJDBCIntegrationSuite with SharedSQLCo
val df = dfRead.filter(dfRead.col("date_type").lt(dt))
.filter(dfRead.col("timestamp_type").lt(ts))
+ val parentPlan = df.queryExecution.executedPlan
+ assert(parentPlan.isInstanceOf[WholeStageCodegenExec])
+ val node = parentPlan.asInstanceOf[WholeStageCodegenExec]
+ val metadata = node.child.asInstanceOf[RowDataSourceScanExec].metadata
+ // The "PushedFilters" part should be exist in Dataframe's
+ // physical plan and the existence of right literals in
+ // "PushedFilters" is used to prove that the predicates
+ // pushing down have been effective.
+ assert(metadata.get("PushedFilters").ne(None))
--- End diff --
nit: Could we use `isDefined` instead of `ne(None)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
