Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18700#discussion_r134237582
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -58,44 +58,11 @@ private[sql] class HiveSessionCatalog(
parser,
functionResourceLoader) {
- override def makeFunctionBuilder(funcName: String, className: String):
FunctionBuilder = {
- makeFunctionBuilder(funcName, Utils.classForName(className))
- }
-
- /**
- * Construct a [[FunctionBuilder]] based on the provided class that
represents a function.
- */
- private def makeFunctionBuilder(name: String, clazz: Class[_]):
FunctionBuilder = {
- // When we instantiate hive UDF wrapper class, we may throw exception
if the input
- // expressions don't satisfy the hive UDF, such as type mismatch,
input number
- // mismatch, etc. Here we catch the exception and throw
AnalysisException instead.
+ override def makeFunctionBuilder(name: String, functionClassName:
String): FunctionBuilder = {
--- End diff --
do we still need to overwrite this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
