Github user janewangfb commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18492#discussion_r134334889
  
    --- Diff: 
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
    @@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite
         assert(numExecutorsTarget(manager) === 10)
       }
     
    +  test("add executors when speculative tasks added") {
    +    sc = createSparkContext(0, 10, 0)
    +    val manager = sc.executorAllocationManager.get
    +
    +    // Verify that we're capped at number of tasks including the 
speculative ones in the stage
    +    sc.listenerBus.postToAll(SparkListenerSpeculativeTaskSubmitted(1))
    --- End diff --
    
    That is not likely. Speculative job is only submitted when certain 
percentage of jobs have finished successfully.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to