Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/18488
  
    I don't feel especially qualified to review this, and I'm hesitant because 
I know the core encoder/decoder framework is an important piece that needs some 
care.
    
    Your change looks good though. It does seem carefully targeted at only 
changing the enum cases, has tests, and does fix an identified problem that 
prevents a normal use case from working.
    
    Am I right that this serializes enums as their string value?
    
    Are there any downsides to this change -- am I missing any behavior it 
changes or breaks?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to