Github user goldmedal commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r134469528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -202,5 +203,9 @@ private[sql] class JacksonGenerator(
*/
def write(array: ArrayData): Unit = writeArray(writeArrayData(array,
arrElementWriter))
+ def write(map: MapData, mapType: MapType): Unit = {
--- End diff --
sorry to reply too late.
I thought that others `write` function don't take any type because
`JacksonGenerator` has a `schema` member. Because `writeMapData` needs
`mapType`, I made `write` function of `MapType` take it.
I try to fix this problem by making `childType` matching move to
`JacksonGenerator` in new commits a254f89 but I'm not sure if this way is
better.
@HyukjinKwon @viirya How do you thinks about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
