Github user mike0sv commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18488#discussion_r134480556
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
 ---
    @@ -154,13 +154,13 @@ case class StaticInvoke(
         val evaluate = if (returnNullable) {
           if (ctx.defaultValue(dataType) == "null") {
             s"""
    -          ${ev.value} = $callFunc;
    +          ${ev.value} = (($javaType) ($callFunc));
    --- End diff --
    
    explicitly cast value to needed type, because without this generated code 
didn't compile with something like "cannot assign value of type Enum to 
%RealEnumClassName%


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to