Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/18973#discussion_r134595799
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala
---
@@ -451,6 +451,17 @@ class StreamingQuerySuite extends StreamTest with
BeforeAndAfter with Logging wi
assert(progress.sources(0).numInputRows === 10)
}
+ test("[SPARK-19690] stream join with aggregate batch query succeeds") {
--- End diff --
Can you move this to the StreamingAggregationSuite? Because that suite is
closely related to this aggregation bug. And I would rename it to "SPARK-19690:
do not convert batch aggregation in streaming query to streaming aggregation"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
