Github user heary-cao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18961#discussion_r134641150
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -31,11 +31,22 @@ object InterpretedPredicate {
       def create(expression: Expression, inputSchema: Seq[Attribute]): 
InterpretedPredicate =
         create(BindReferences.bindReference(expression, inputSchema))
     
    -  def create(expression: Expression): InterpretedPredicate = new 
InterpretedPredicate(expression)
    +  def create(expression: Expression): InterpretedPredicate = {
    +    val predicate = new InterpretedPredicate(expression)
    +    predicate.initialize(0)
    --- End diff --
    
    we not need InterpretedPredicate.initialize and modify _object 
InterpretedPredicate.create_
    ```
      def create(expression: Expression): InterpretedPredicate = {
        expression.foreach {
          case n: Nondeterministic => n.initialize(0)
          case _ =>
        }
        new InterpretedPredicate(expression)
      }
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to