Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19025#discussion_r134657843
--- Diff: core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java
---
@@ -74,7 +74,7 @@
* Maximum supported data page size (in bytes). In principle, the
maximum addressable page size is
* (1L << OFFSET_BITS) bytes, which is 2+ petabytes. However, the
on-heap allocator's
* maximum page size is limited by the maximum amount of data that can
be stored in a long[]
- * array, which is (2^32 - 1) * 8 bytes (or 16 gigabytes). Therefore, we
cap this at 16 gigabytes.
+ * array, which is (2^31 - 1) * 8 bytes (or 16 gigabytes). Therefore, we
cap this at 16 gigabytes.
--- End diff --
"or about 17 gigabytes" is correct, and it's not capped at 16 gigabytes,
but the value in the previous sentence. I'd just say "cap at this value".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
