Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134779475
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +306,69 @@ public void update(int ordinal, Object value) {
@Override
public void setNullAt(int ordinal) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNull(rowId);
+ getColumnAsWritable(ordinal).putNull(rowId);
}
@Override
public void setBoolean(int ordinal, boolean value) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNotNull(rowId);
- columns[ordinal].putBoolean(rowId, value);
+ WritableColumnVector column = getColumnAsWritable(ordinal);
+ column.putNotNull(rowId);
+ column.putBoolean(rowId, value);
}
@Override
public void setByte(int ordinal, byte value) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNotNull(rowId);
- columns[ordinal].putByte(rowId, value);
+ WritableColumnVector column = getColumnAsWritable(ordinal);
+ column.putNotNull(rowId);
+ column.putByte(rowId, value);
}
@Override
public void setShort(int ordinal, short value) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNotNull(rowId);
- columns[ordinal].putShort(rowId, value);
+ WritableColumnVector column = getColumnAsWritable(ordinal);
+ column.putNotNull(rowId);
+ column.putShort(rowId, value);
}
@Override
public void setInt(int ordinal, int value) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNotNull(rowId);
- columns[ordinal].putInt(rowId, value);
+ WritableColumnVector column = getColumnAsWritable(ordinal);
+ column.putNotNull(rowId);
+ column.putInt(rowId, value);
}
@Override
public void setLong(int ordinal, long value) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNotNull(rowId);
- columns[ordinal].putLong(rowId, value);
+ WritableColumnVector column = getColumnAsWritable(ordinal);
+ column.putNotNull(rowId);
+ column.putLong(rowId, value);
}
@Override
public void setFloat(int ordinal, float value) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNotNull(rowId);
- columns[ordinal].putFloat(rowId, value);
+ WritableColumnVector column = getColumnAsWritable(ordinal);
+ column.putNotNull(rowId);
+ column.putFloat(rowId, value);
}
@Override
public void setDouble(int ordinal, double value) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNotNull(rowId);
- columns[ordinal].putDouble(rowId, value);
+ WritableColumnVector column = getColumnAsWritable(ordinal);
+ column.putNotNull(rowId);
+ column.putDouble(rowId, value);
}
@Override
public void setDecimal(int ordinal, Decimal value, int precision) {
- assert (!columns[ordinal].isConstant);
- columns[ordinal].putNotNull(rowId);
- columns[ordinal].putDecimal(rowId, value, precision);
+ WritableColumnVector column = getColumnAsWritable(ordinal);
+ column.putNotNull(rowId);
+ column.putDecimal(rowId, value, precision);
+ }
+
+ private WritableColumnVector getColumnAsWritable(int ordinal) {
--- End diff --
nit: `getWritableColumn`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
