Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19017#discussion_r134931120
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -447,7 +448,18 @@ case class JsonTuple(children: Seq[Expression])
generator => copyCurrentStructure(generator, parser)
}
- row(idx) = UTF8String.fromBytes(output.toByteArray)
+ val jsonValue = UTF8String.fromBytes(output.toByteArray)
+ row(idx) = jsonValue
+ idx = idx + 1
+
+ // SPARK-21804: json_tuple returns null values within repeated
columns
+ // except the first one; so that we need to check the
remaining fields.
+ while (idx < fieldNames.length) {
+ if (fieldNames(idx) == jsonField) {
+ row(idx) = jsonValue
+ }
+ idx = idx + 1
+ }
--- End diff --
```Scala
row(idx) = jsonValue
idx = idx + 1
// SPARK-21804: json_tuple returns null values within repeated
columns
// except the first one; so that we need to check the remaining
fields.
while (idx < fieldNames.length) {
if (fieldNames(idx) == jsonField) {
row(idx) = jsonValue
}
idx = idx + 1
}
```
->
```Scala
do {
row(idx) = jsonValue
idx = fieldNames.indexOf(jsonField, idx + 1)
} while (idx >= 0)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
