Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19038#discussion_r134989277
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetricsSuite.scala
---
@@ -23,18 +23,16 @@ import org.apache.spark.mllib.util.TestingUtils._
class BinaryClassificationMetricsSuite extends SparkFunSuite with
MLlibTestSparkContext {
- private def areWithinEpsilon(x: (Double, Double)): Boolean = x._1 ~=
(x._2) absTol 1E-5
-
- private def pairsWithinEpsilon(x: ((Double, Double), (Double, Double))):
Boolean =
- (x._1._1 ~= x._2._1 absTol 1E-5) && (x._1._2 ~= x._2._2 absTol 1E-5)
-
- private def assertSequencesMatch(left: Seq[Double], right: Seq[Double]):
Unit = {
- assert(left.zip(right).forall(areWithinEpsilon))
+ private def assertSequencesMatch(actual: Seq[Double], expected:
Seq[Double]): Unit = {
--- End diff --
90% of the changes in this file were to improve the error log message and
clean up the code a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
